Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

jeff-allen-mongo
Copy link
Collaborator

@jeff-allen-mongo jeff-allen-mongo commented Mar 20, 2025

DESCRIPTION

Add instructions on how to verify mongosync binaries.

STAGING

Verify Integrity of mongosync Packages

(and sub-pages)

JIRA

https://jira.mongodb.org/browse/DOCSP-40664

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for docs-cluster-to-cluster-sync ready!

Name Link
🔨 Latest commit 453ed56
🔍 Latest deploy log https://app.netlify.com/sites/docs-cluster-to-cluster-sync/deploys/67e2cc6fc826c900085ace2e
😎 Deploy Preview https://deploy-preview-686--docs-cluster-to-cluster-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@autarch autarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % one small nit and one question! ✅

@@ -0,0 +1,4 @@
The MongoDB release team digitally signs ``mongosync`` packages to
certify that packages are a valid and unaltered MongoDB release. Before
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] Should there be a "the" before "packages" ?

Suggested change
certify that packages are a valid and unaltered MongoDB release. Before
certify that the packages are a valid and unaltered MongoDB release. Before

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, updating.

gpg: Total number processed: 1
gpg: imported: 1
If you have previously imported the key, the command returns:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[praise] thanks for considering this condition!

gpg: using RSA key D4E45C292A5C94962F0D10E13132835C1D925D5B
gpg: Good signature from "MongoDB CLI Tools Release Signing Key <[email protected]>" [unknown]

If the package is signed but the signing key is not added to your
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question] What would cause the signing key to not be added to the local trustdb? Is there a case where users import the MDB Server Tools public key and it gets imported elsewhere?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking a key as trusted is a manual action that the person running gpg needs to take. By default, no keys are trusted. How would someone decide whether to trust a particular key? Uh .... you're supposed to meet up with people in person and verify their credentials and have them hand you their key. Seriously!

This is one reason why gpg is not a good choice for this sort signature verification. Long-term, I'd love to see MongoDB move to a different key system that has a better story around trust and verification. The sistore project looks promising, as does GitHub Attestations.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh gotcha! Wasn't super familiar with verification and whatnot, so this is helpful to know!

@jeff-allen-mongo jeff-allen-mongo merged commit 5a55fdb into mongodb:master Mar 25, 2025
4 checks passed
@jeff-allen-mongo jeff-allen-mongo deleted the DOCSP-40664 branch March 25, 2025 18:00
jeff-allen-mongo added a commit to jeff-allen-mongo/docs-cluster-to-cluster-sync that referenced this pull request Mar 25, 2025
* WIP

* DOCSP-40664-verify-package-signatures

* fixes

* edits

* fix variable

* review feedback

(cherry picked from commit 5a55fdb)
jeff-allen-mongo added a commit to jeff-allen-mongo/docs-cluster-to-cluster-sync that referenced this pull request Mar 25, 2025
* WIP

* DOCSP-40664-verify-package-signatures

* fixes

* edits

* fix variable

* review feedback

(cherry picked from commit 5a55fdb)
jeff-allen-mongo added a commit to jeff-allen-mongo/docs-cluster-to-cluster-sync that referenced this pull request Mar 25, 2025
* WIP

* DOCSP-40664-verify-package-signatures

* fixes

* edits

* fix variable

* review feedback

(cherry picked from commit 5a55fdb)
@jeff-allen-mongo
Copy link
Collaborator Author

💚 All backports created successfully

Status Branch Result
v1.11
v1.10
v1.9
v1.8

Questions ?

Please refer to the Backport tool documentation

jeff-allen-mongo added a commit to jeff-allen-mongo/docs-cluster-to-cluster-sync that referenced this pull request Mar 25, 2025
* WIP

* DOCSP-40664-verify-package-signatures

* fixes

* edits

* fix variable

* review feedback

(cherry picked from commit 5a55fdb)
jeff-allen-mongo added a commit that referenced this pull request Mar 25, 2025
* WIP

* DOCSP-40664-verify-package-signatures

* fixes

* edits

* fix variable

* review feedback

(cherry picked from commit 5a55fdb)
jeff-allen-mongo added a commit that referenced this pull request Mar 25, 2025
* WIP

* DOCSP-40664-verify-package-signatures

* fixes

* edits

* fix variable

* review feedback

(cherry picked from commit 5a55fdb)
jeff-allen-mongo added a commit that referenced this pull request Mar 25, 2025
* WIP

* DOCSP-40664-verify-package-signatures

* fixes

* edits

* fix variable

* review feedback

(cherry picked from commit 5a55fdb)
jeff-allen-mongo added a commit that referenced this pull request Mar 25, 2025
* WIP

* DOCSP-40664-verify-package-signatures

* fixes

* edits

* fix variable

* review feedback

(cherry picked from commit 5a55fdb)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants